On Tue, Aug 13, 2013 at 10:50 AM, Alex Wang <al...@nicira.com> wrote:
> I think the intention is right here, but it's a bit odd. For example, >> if in_decay is true, we don't drop out of it with this logic in all >> cases. How about we add a boolean to this function >> "cfm_min_rx_changed" and set it to true here. If that's true, then in >> the next if statement we can run through the decay_min_rx changed >> logic which we know is correct. > > > > > I think the reset here is necessary. Since we do not allow "decay_min_rx < > cfg_min_rx", we need to check the validity of "decay_min_rx" every time > "cfg_min_rx" is changed. > I now understand this comment. There is actually a bug with my implementation, if bfd is in decay, and we set (min_rx to some value) and (decay_min_rx to 0) together. I'll fix accordingly.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
