Re: [ovs-dev] [PATCH 5/8] bridge: Remove the 'Instant' stats.

2014-04-09 Thread Ben Pfaff
On Wed, Apr 09, 2014 at 04:31:46PM -0700, Alex Wang wrote: > On Wed, Apr 9, 2014 at 4:13 PM, Ben Pfaff wrote: > > I also don't quite follow this comment in > > iface_refresh_ofproto_status(), because it talks about a change to > > status but actually checks for an error fetching status: > > > > >

Re: [ovs-dev] [PATCH 5/8] bridge: Remove the 'Instant' stats.

2014-04-09 Thread Alex Wang
Thx for the review Ben, please see my reply inline On Wed, Apr 9, 2014 at 4:13 PM, Ben Pfaff wrote: > On Fri, Apr 04, 2014 at 03:00:40PM -0700, Alex Wang wrote: > > This commit removes the "Instant" stats related logic in bridge.c > > by moving the logic into iface_refresh_ofproto_status() and

Re: [ovs-dev] [PATCH 5/8] bridge: Remove the 'Instant' stats.

2014-04-09 Thread Ben Pfaff
On Fri, Apr 04, 2014 at 03:00:40PM -0700, Alex Wang wrote: > This commit removes the "Instant" stats related logic in bridge.c > by moving the logic into iface_refresh_ofproto_status() and using > the global sequence number to check whether or not to call it. > > Also, the 'netdev''s 'change_seq'