I changed the commit message to this:
While this code is useful for debugging, removing it allows us to hide
ofproto_trace() in ofproto-dpif. ofproto_trace() is a complex function
which could be difficult to make "obviously" thread safe.
Thanks for the review,
Ethan
On Fri, Aug 2, 2013 at 10:25
On Fri, Aug 02, 2013 at 10:14:02PM -0700, Ethan Jackson wrote:
> > I thought we introduced this to make debugging easier in real problem
> > situations. It would be pretty easy to make thread safe with an
> > atomic_bool.
>
> I'm more worried about accessing the ofproto_trace() function from
> ou
> I thought we introduced this to make debugging easier in real problem
> situations. It would be pretty easy to make thread safe with an
> atomic_bool.
I'm more worried about accessing the ofproto_trace() function from
outside of ofproto_dpif. I'm trying to keep the interface in
ofproto-dpif.h
On Fri, Aug 02, 2013 at 06:31:38PM -0700, Ethan Jackson wrote:
> This code is not particularly important and will be inconvenient to
> make thread safe.
>
> Signed-off-by: Ethan Jackson
I thought we introduced this to make debugging easier in real problem
situations. It would be pretty easy to
