On Fri, Aug 02, 2013 at 10:14:02PM -0700, Ethan Jackson wrote: > > I thought we introduced this to make debugging easier in real problem > > situations. It would be pretty easy to make thread safe with an > > atomic_bool. > > I'm more worried about accessing the ofproto_trace() function from > outside of ofproto_dpif. I'm trying to keep the interface in > ofproto-dpif.h small, simple, and easy to lock down from a concurrency > perspective. Perhaps removing the feature altogether is overkill, but > I'm not sure of the trade offs either way.
That reads to me as better rationale, please mention it in the commit message. Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
