Re: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is installed

2016-06-07 Thread Alin Serdean
> > Hi guys! > > Thanks for the review! > Now I see that I didn't fully understood what AT_CAPTURE_FILE macro does > when I wrote the patch (this was my first contact with autoconf testsuites). [Alin Gabriel Serdean: ] It is a tough cookie at first :). You are doing well! > I will send another on

Re: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is installed

2016-06-07 Thread Paul Boca
From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, June 7, 2016 7:28 AM > To: Alin Serdean > Cc: Paul Boca; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is > installed > > On Mon, Jun 06, 2016 at 08:21:26PM +, Alin Ser

Re: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is installed

2016-06-06 Thread Ben Pfaff
On Mon, Jun 06, 2016 at 08:21:26PM +, Alin Serdean wrote: > > -Mesaj original- > > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > > Trimis: Friday, June 3, 2016 4:07 PM > > Către: dev@openvswitch.org > > Subiect: [ovs-dev] [PATCH] tests: Skip vlog close and set if

Re: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is installed

2016-06-06 Thread Ben Pfaff
On Fri, Jun 03, 2016 at 01:06:51PM +, Paul Boca wrote: > AT_CAPTURE_FILE([log.old]) and AT_CAPTURE_FILE([log]) will fail in case no > python > is installed on the system > > Signed-off-by: Paul-Daniel Boca I don't understand this. AT_CAPTURE_FILE doesn't rely on Python. Also, AT_CAPTURE_F

Re: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is installed

2016-06-06 Thread Alin Serdean
That will disable the test if it is under > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca > Trimis: Friday, June 3, 2016 4:07 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH] tests: Skip vlog close and set if no python is > installed >