> > Hi guys! > > Thanks for the review! > Now I see that I didn't fully understood what AT_CAPTURE_FILE macro does > when I wrote the patch (this was my first contact with autoconf testsuites). [Alin Gabriel Serdean: ] It is a tough cookie at first :). You are doing well! > I will send another one with Alin's suggestion. [Alin Gabriel Serdean: ] As Ben indirectly suggested there were too many code changes so I dived deeper into the actual problem. The actual problem is the following: https://github.com/openvswitch/ovs/blob/master/tests/vlog.at#L282-L283 The reason behind it is the "--detach" command argument which is implemented under windows in: https://github.com/openvswitch/ovs/blob/master/lib/daemon-windows.c#L341-L404 Apparently the first message does not get propagated to "stderr" I don't know if this would be appropriate but to fix just the tests we could do the following: diff --git a/tests/vlog.at b/tests/vlog.at index b793611..0ff5cfd 100644 --- a/tests/vlog.at +++ b/tests/vlog.at @@ -279,7 +279,8 @@ AT_CAPTURE_FILE([log]) AT_CAPTURE_FILE([log.old]) AT_CHECK([ovstest test-unixctl --log-file=`pwd`/log --pidfile --detach], [0], [], [stderr]) -AT_CHECK([vlog_filt stderr], [0], [opened log file +AT_CHECK([vlog_filt log], [0], [opened log file +Entering run loop. ])
AT_CHECK([APPCTL -t test-unixctl log message]) @@ -356,7 +357,8 @@ on_exit 'kill `cat test-unixctl.pid`' AT_CAPTURE_FILE([log]) AT_CHECK([ovstest test-unixctl --log-file=`pwd`/log --pidfile --detach], [0], [], [stderr]) -AT_CHECK([vlog_filt stderr], [0], [opened log file +AT_CHECK([vlog_filt log], [0], [opened log file +Entering run loop. ]) AT_CHECK([APPCTL -t test-unixctl vlog/list | sed -n '1,2p Tested on Linux and Windows. > > Thanks, > Paul > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
