Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-20 Thread Jarno Rajahalme
> On May 20, 2015, at 11:43 AM, Justin Pettit wrote: > > >> On May 20, 2015, at 11:33 AM, Andy Zhou wrote: >> >> Justin suggested changing to decimal. It seems reasonable to me as >> well since we don't wildcard recirc_id at the moment as you have >> pointed out. >> >> In case we do wildcard

Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-20 Thread Andy Zhou
O.K. I will revert this patch, and submit a new one that changes recirc_id in action. On Wed, May 20, 2015 at 11:43 AM, Justin Pettit wrote: > >> On May 20, 2015, at 11:33 AM, Andy Zhou wrote: >> >> Justin suggested changing to decimal. It seems reasonable to me as >> well since we don't wildcar

Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-20 Thread Justin Pettit
> On May 20, 2015, at 11:33 AM, Andy Zhou wrote: > > Justin suggested changing to decimal. It seems reasonable to me as > well since we don't wildcard recirc_id at the moment as you have > pointed out. > > In case we do wildcard recirc_id down the road, I'd lean towards your > proposal. If it

Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-20 Thread Andy Zhou
Justin suggested changing to decimal. It seems reasonable to me as well since we don't wildcard recirc_id at the moment as you have pointed out. In case we do wildcard recirc_id down the road, I'd lean towards your proposal. On Wed, May 20, 2015 at 9:42 AM, Joe Stringer wrote: > On 18 May 2015

Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-20 Thread Joe Stringer
On 18 May 2015 at 18:26, Andy Zhou wrote: > The output of 'ovs-ofctl dump-flows' command prints recirc_id in decimal > in action parts of the output, while prints that in hex in matching > parts of the same output. > > This patch fixes the inconsistency by always printing recirc_id > values in dec

Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-19 Thread Andy Zhou
Thank you both Ben and Jarno for the review. Pushed to master. On Tue, May 19, 2015 at 11:42 AM, Jarno Rajahalme wrote: > LGTM, > > Jarno > > Acked-by: Jarno Rajahalme > >> On May 18, 2015, at 6:26 PM, Andy Zhou wrote: >> >> The output of 'ovs-ofctl dump-flows' command prints recirc_id in dec

Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-19 Thread Jarno Rajahalme
LGTM, Jarno Acked-by: Jarno Rajahalme > On May 18, 2015, at 6:26 PM, Andy Zhou wrote: > > The output of 'ovs-ofctl dump-flows' command prints recirc_id in decimal > in action parts of the output, while prints that in hex in matching > parts of the same output. > > This patch fixes the inco

Re: [ovs-dev] [PATCH] ovs-ofctl: Always prints recirc_id in decimal

2015-05-19 Thread Ben Pfaff
On Mon, May 18, 2015 at 06:26:28PM -0700, Andy Zhou wrote: > The output of 'ovs-ofctl dump-flows' command prints recirc_id in decimal > in action parts of the output, while prints that in hex in matching > parts of the same output. > > This patch fixes the inconsistency by always printing recirc_i