> On May 20, 2015, at 11:43 AM, Justin Pettit <jpet...@nicira.com> wrote:
>
>
>> On May 20, 2015, at 11:33 AM, Andy Zhou <az...@nicira.com> wrote:
>>
>> Justin suggested changing to decimal. It seems reasonable to me as
>> well since we don't wildcard recirc_id at the moment as you have
>> pointed out.
>>
>> In case we do wildcard recirc_id down the road, I'd lean towards your
>> proposal.
>
> If it's maskable, let's go with hex. Changing the output later makes life
> difficult for people who write tests that try to parse the output.
>
This is what we have in lib/meta-flow.h:
/* "recirc_id".
*
* ID for recirculation. The value 0 is reserved for initially received
* packets. Internal use only, not programmable from controller.
*
* Type: be32.
* Maskable: no.
* Formatting: decimal.
* Prerequisites: none.
* Access: read-only.
* NXM: NXM_NX_RECIRC_ID(36) since v2.2.
* OXM: none.
*/
The current strategy for recirc-id allocation is to get the next free one,
which is essentially unsuitable for masking.
If we want to make a future change to maskable easier, then that is a different
issue
Jarno
> --Justin
>
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
