Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ethan Jackson
Thanks, I've pushed this. Ethan On Wed, Jan 11, 2012 at 11:28, Ben Pfaff wrote: > Thanks, I'm happy with this. > > On Wed, Jan 11, 2012 at 11:27:00AM -0800, Ethan Jackson wrote: >> I agree this is a bit subtle.  Here's an updated version of the patch. >> >> --- >> A "packet out" ordinarily isn'

Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ben Pfaff
Thanks, I'm happy with this. On Wed, Jan 11, 2012 at 11:27:00AM -0800, Ethan Jackson wrote: > I agree this is a bit subtle. Here's an updated version of the patch. > > --- > A "packet out" ordinarily isn't accounted to any OpenFlow rule, > because its actions come directly from the controller in

Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ben Pfaff
On Tue, Jan 10, 2012 at 08:19:17PM -0800, Ethan Jackson wrote: > Reported-by: Jesse Gross > Signed-off-by: Ethan Jackson > --- > > Jesse tested this, I've only compiled it. The patch looks good, but it took me a while to understand the rationale here. Let me add to your changelog (or you can e