On Tue, Jan 10, 2012 at 08:19:17PM -0800, Ethan Jackson wrote:
> Reported-by: Jesse Gross <je...@nicira.com>
> Signed-off-by: Ethan Jackson <et...@nicira.com>
> ---
>
> Jesse tested this, I've only compiled it.
The patch looks good, but it took me a while to understand the
rationale here. Let me add to your changelog (or you can explain why
I'm wrong):
A "packet out" ordinarily isn't accounted to any OpenFlow rule,
because its actions come directly from the controller instead of from
an OpenFlow rule. However, any "resubmit" actions or output to
OFPP_TABLE within the set of actions do bring in actions from a rule,
and the "packet out" should be accounted to the rule in that case.
This commit implements that behavior.
Maybe also add a comment, e.g.
/* Ensure that resubmits in the actions get accounted to their matching
* rules. */
Thanks,
Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
