Re: [ovs-dev] [PATCH] Fully initialize data structures.

2013-07-19 Thread Ben Pfaff
On Fri, Jul 19, 2013 at 10:35:20AM -0700, Alex Wang wrote: > Then, should we also change the "-Wno-override-init" to "-Woverride-init"? I haven't thought about that warning option since 2009 when I introduced it. It looks like we're clean on -Wextra, which enables -Woverride-init and some others.

Re: [ovs-dev] [PATCH] Fully initialize data structures.

2013-07-19 Thread Ben Pfaff
On Thu, Jul 18, 2013 at 06:06:44PM -0700, Linda Sun wrote: > Signed-off-by: Linda Sun I folded in the following incremental to fix up a few style issues, and then applied this to master. Thanks, Ben. diff --git a/lib/odp-util.c b/lib/odp-util.c index c12e2fe..5a32221 100644 --- a/lib/odp-util.

Re: [ovs-dev] [PATCH] Fully initialize data structures.

2013-07-19 Thread Alex Wang
Hey, Then, should we also change the "-Wno-override-init" to "-Woverride-init"? I also had related warning when compiling with clang. And these two patches fix it. Kind Regards, Alex Wang, On Fri, Jul 19, 2013 at 10:09 AM, Ben Pfaff wrote: > On Thu, Jul 18, 2013 at 06:06:44PM -0700, Linda Sun

Re: [ovs-dev] [PATCH] Fully initialize data structures.

2013-07-18 Thread Ben Pfaff
On Wed, Jul 17, 2013 at 04:45:32PM -0700, Linda Sun wrote: > Reference arrays after its definition. > > Signed-off-by: Linda Sun I have a different suggestion for netlink.c. I posted the patch here: http://openvswitch.org/pipermail/dev/2013-July/029752.html Will you review it, please?