On Wed, Jul 17, 2013 at 04:45:32PM -0700, Linda Sun wrote:
> Reference arrays after its definition.
> 
> Signed-off-by: Linda Sun <l...@vmware.com>

I have a different suggestion for netlink.c.  I posted the patch here:
        http://openvswitch.org/pipermail/dev/2013-July/029752.html
Will you review it, please?

Please use /**/ comments instead of // comments, as CodingStyle
recommends.

This patch adds blank lines at the end of some files.  Please remove
them.

Please add to the comment above ofpp_none_bundle that explains where
it gets initialized.

I don't like moving around so much code in ovs-vsctl.c.  In that file,
instead of moving around so much code, please introduce a function
that returns all_commands.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to