Re: [ovs-dev] fix compilation on FreeBSD

2012-06-29 Thread Ethan Jackson
> If Ethan tells us his plan, then maybe we can just execute that > instead of implementing for BSD.  Ceteris paribus, I agree that it's > better to delete code than to add more of it! My plan is basically to delete the route_table code entirely because the features it implements aren't particular

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-29 Thread Ben Pfaff
On Fri, Jun 29, 2012 at 09:44:55AM -0400, Ed Maste wrote: > On 28 June 2012 23:15, Ben Pfaff wrote: > > The route-table implementation is definitely not portable, but I don't > > think there's anything in the interface that can't be implemented in > > FreeBSD.  One proper solution, then, would be

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-29 Thread Ed Maste
On 28 June 2012 23:15, Ben Pfaff wrote: > The route-table implementation is definitely not portable, but I don't > think there's anything in the interface that can't be implemented in > FreeBSD.  One proper solution, then, would be to add an implementation > that works in FreeBSD.  I'd certainly t

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-28 Thread Ben Pfaff
The route-table implementation is definitely not portable, but I don't think there's anything in the interface that can't be implemented in FreeBSD. One proper solution, then, would be to add an implementation that works in FreeBSD. I'd certainly take such an implementation. Ethan, I can't remem

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-28 Thread Ethan Jackson
FWIW it seems to me that our use of route_table_get_name() is a bit of a layering violation. Given that netdev-vport and ofproto-dpif-sflow should be portable, they shouldn't call into linux specific code. Ideally I'd love to simply ditch the route_table code entirely, but I'm not sure I have time

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-28 Thread Ben Pfaff
I think it would be better to implement route_table_get_name() under FreeBSD. At any rate, I can't apply a patch that adds such invasive #ifdefs, so at a minimum we'll have to figure out a better way to do this. ___ dev mailing list dev@openvswitch.org h

Re: [ovs-dev] fix compilation on FreeBSD

2012-06-28 Thread Giuseppe Lettieri
Sorry, here is the patch that was to supposed to be attached to the previous message. Best regards, Giuseppe Lettieri Il 28/06/2012 11:10, Giuseppe Lettieri ha scritto: > Hi, > > we are working on a port of Open vSwitch to FreeBSD. This patch is a > first step toward that direction. It only allo

[ovs-dev] fix compilation on FreeBSD

2012-06-28 Thread Giuseppe Lettieri
Hi, we are working on a port of Open vSwitch to FreeBSD. This patch is a first step toward that direction. It only allows clean compilation of the git master branch with default configuration. It protects the changes that were introduced in commit 733adf2a, so that they are only enabled on Linux w