Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-14 Thread Saurabh Shah
..@vmware.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" mailto:dev@openvswitch.org>> Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal If I leave OvsPub.h and OvsDpInterface.h intact, should I also leave OvsNetlink.h intact? Sam

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-14 Thread Samuel Ghinet
: [ovs-dev] datapath-windows: Renaming files proposal Hi Samuel, > >OvsNetlink.h -> Netlink.h >OvsPub.h -> Pub.h > >The following will be left intact: >OvsDpInterface.h >Because it is a userspace interaction file and it is a generated file. I think I tried to tell this

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Saurabh Shah
Hi Samuel, > >OvsNetlink.h -> Netlink.h >OvsPub.h -> Pub.h > >The following will be left intact: >OvsDpInterface.h >Because it is a userspace interaction file and it is a generated file. I think I tried to tell this earlier, so this will be a repeat. If you want to nuke ŒOvs¹ please remove it fro

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Nithin Raju
On Aug 13, 2014, at 5:32 PM, Samuel Ghinet mailto:sghi...@cloudbasesolutions.com>> wrote: I meant, tell me whether you prefer Eth.h or Ethernet.h I have a slight preference for Ethernet.h, but it's no big deal to me. hi Sam, Since you are making the change, I'll go with your preference. Etherne

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Samuel Ghinet
h.org Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Okay, so I'm gonna make a patch which will nuke the Ovs prefix of the following files: OvsActions.c -> Actions.c OvsAtomic.h -> Atomic.h OvsBufferMgmt.c -> BufferMgmt.c OvsBufferMgmt.h -> BufferMgmt.h OvsCh

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Nithin Raju
On Aug 13, 2014, at 5:21 PM, Samuel Ghinet mailto:sghi...@cloudbasesolutions.com>> wrote: OvsEth.h -> Ethernet.h [TELL ME IF YOU PREFER "Eth.h"] I like Eth.h, just my opinion though. The following will be left intact: OvsDpInterface.h Because it is a userspace interaction file and it is a gen

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Samuel Ghinet
_ From: Nithin Raju [nit...@vmware.com] Sent: Thursday, August 14, 2014 2:36 AM To: Ankur Sharma; Saurabh Shah; Samuel Ghinet Cc: dev@openvswitch.org Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Sam and Alin are of the opinion that we should nuke 'Ovs&#

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Nithin Raju
. Thanks! -- Nithin From: Ankur Sharma Sent: Wednesday, August 13, 2014 4:31 PM To: Saurabh Shah; Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Correct, i think userspace interaction headers should have Ovs prefix. Regards, A

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Saurabh Shah
prefix, that's fine with me. -- Saurabh From: Ankur Sharma Sent: Wednesday, August 13, 2014 4:31 PM To: Saurabh Shah; Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Correct, i think userspace interaction heade

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Ankur Sharma
mailto:sghi...@cloudbasesolutions.com>>, Nithin Raju mailto:nit...@vmware.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" mailto:dev@openvswitch.org>> Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Hi, The reason we decided to keep Ovs with DpInterfac

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Saurabh Shah
m>>, Nithin Raju mailto:nit...@vmware.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" mailto:dev@openvswitch.org>> Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Hi, The reason we decided to keep Ovs with DpInterface was bec

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Ankur Sharma
, Ankur From: dev on behalf of Saurabh Shah Sent: Wednesday, August 13, 2014 3:39 PM To: Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal +1 for dropping the 'Ovs' prefix for OvsD

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Saurabh Shah
: "dev@openvswitch.org<mailto:dev@openvswitch.org>" mailto:dev@openvswitch.org>> Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal Nithin, Reasonable. I was actually thinking that if I want to remove Ovs-prefixes from all files except this one, some people

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Alin Serdean
+1 -Mesaj original- De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Wednesday, August 13, 2014 6:33 PM Către: Samuel Ghinet Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] datapath-windows: Renaming files proposal On Aug 13, 2014, at 8:29 AM, Samuel Ghinet

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Nithin Raju
On Aug 13, 2014, at 8:29 AM, Samuel Ghinet wrote: > However, I would remove "Ovs" from OvsPub.h and OvsNetlink.h. > Would that be ok to you? Totally fine! OvsPub.h is the legacy interface and will be nuked as soon as the netlink based interface is ready. OvsNetlink.h will be moved back within

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Samuel Ghinet
you? Sam From: Nithin Raju [nit...@vmware.com] Sent: Wednesday, August 13, 2014 6:15 PM To: Samuel Ghinet Cc: dev@openvswitch.org Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal Sam, OvsDpInterface.h is basically the OVS datapath's interface. It is being generate

Re: [ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Nithin Raju
Sam, OvsDpInterface.h is basically the OVS datapath's interface. It is being generated in a separate directory - sort of public for the datapath - to be sure. I'm inclined to leave the Ovs keyword alone for this 'OVS interface' file. Is that reasonable? thanks, Nithin On Aug 13, 2014, at 8:11

[ovs-dev] datapath-windows: Renaming files proposal

2014-08-13 Thread Samuel Ghinet
Hello guys, Just to make sure that everyone agrees to this. I want to add a commit in which to rename all files, by removing the prefix Ovs. E.g. OvsActions.c -> Actions.c Since there is no use in having the prefix "Ovs", and removing it may improve clarity. (there was a discussion on this on th