Correct, i think userspace interaction headers should have Ovs prefix. Regards, Ankur ________________________________ From: Saurabh Shah Sent: Wednesday, August 13, 2014 4:28 PM To: Ankur Sharma; Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal
If that’s the case, we should also keep the ‘Ovs’ prefix for OvsPub.h. :) Thanks! Saurabh From: Ankur Sharma <ankursha...@vmware.com<mailto:ankursha...@vmware.com>> Date: Wednesday, August 13, 2014 at 4:20 PM To: Saurabh Shah <ssaur...@vmware.com<mailto:ssaur...@vmware.com>>, Samuel Ghinet <sghi...@cloudbasesolutions.com<mailto:sghi...@cloudbasesolutions.com>>, Nithin Raju <nit...@vmware.com<mailto:nit...@vmware.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org>" <dev@openvswitch.org<mailto:dev@openvswitch.org>> Subject: RE: [ovs-dev] datapath-windows: Renaming files proposal Hi, The reason we decided to keep Ovs with DpInterface was because this file defines the interface with ovs userspace, i.e it has a different semantics from other header files in ovsext. I would prefer keeping the Ovs prefix, but its fine if you think it should be renamed. Thanks. Regards, Ankur ________________________________________ From: dev <dev-boun...@openvswitch.org<mailto:dev-boun...@openvswitch.org>> on behalf of Saurabh Shah <ssaur...@vmware.com<mailto:ssaur...@vmware.com>> Sent: Wednesday, August 13, 2014 3:39 PM To: Samuel Ghinet; Nithin Raju Cc: dev@openvswitch.org<mailto:dev@openvswitch.org> Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal +1 for dropping the 'Ovs' prefix for OvsDpInterface. It is odd to have just one file prefixed with Ovs. Thanks! Saurabh From: Samuel Ghinet <sghi...@cloudbasesolutions.com<mailto:sghi...@cloudbasesolutions.com><mailto:sghi...@cloudbasesolutions.com>> Date: Wednesday, August 13, 2014 at 8:29 AM To: Nithin Raju <nit...@vmware.com<mailto:nit...@vmware.com><mailto:nit...@vmware.com>> Cc: "dev@openvswitch.org<mailto:dev@openvswitch.org><mailto:dev@openvswitch.org>" <dev@openvswitch.org<mailto:dev@openvswitch.org><mailto:dev@openvswitch.org>> Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal Nithin, Reasonable. I was actually thinking that if I want to remove Ovs-prefixes from all files except this one, some people may not agree with this small inconsistency :) However, I would remove "Ovs" from OvsPub.h and OvsNetlink.h. Would that be ok to you? Sam ________________________________________ From: Nithin Raju [nit...@vmware.com<mailto:nit...@vmware.com><mailto:nit...@vmware.com>] Sent: Wednesday, August 13, 2014 6:15 PM To: Samuel Ghinet Cc: dev@openvswitch.org<mailto:dev@openvswitch.org><mailto:dev@openvswitch.org> Subject: Re: [ovs-dev] datapath-windows: Renaming files proposal Sam, OvsDpInterface.h is basically the OVS datapath's interface. It is being generated in a separate directory - sort of public for the datapath - to be sure. I'm inclined to leave the Ovs keyword alone for this 'OVS interface' file. Is that reasonable? thanks, Nithin On Aug 13, 2014, at 8:11 AM, Samuel Ghinet <sghi...@cloudbasesolutions.com<mailto:sghi...@cloudbasesolutions.com><mailto:sghi...@cloudbasesolutions.com>> wrote: Hello guys, Just to make sure that everyone agrees to this. I want to add a commit in which to rename all files, by removing the prefix Ovs. E.g. OvsActions.c -> Actions.c Since there is no use in having the prefix "Ovs", and removing it may improve clarity. (there was a discussion on this on the ML) A slight complication has appeared, with the advent of OvsDpInterface.h, which is generated. If I am to remove the Ovs-prefix from the others, I would remove it from OvsDpInterface.h as well, which means renaming it in the .gitignore, automake.mk (in datapath-windows\include) as well. I just want to make sure that everyone is ok with this, before I do the commit :) Sam _______________________________________________ dev mailing list dev@openvswitch.org<mailto:dev@openvswitch.org><mailto:dev@openvswitch.org> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWavCMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJIBGvzo%3D%0A&m=VEHXb76F4IOqrluamPp8Oz8WsFzGBuPsZ1DZHLAhIic%3D%0A&s=07301ed1c1ab2023fcd9c2d06ec980d29a1af54a143c379a229a7d3463ea0a6f _______________________________________________ dev mailing list dev@openvswitch.org<mailto:dev@openvswitch.org><mailto:dev@openvswitch.org> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=pEkjsHfytvHEWufeZPpgqSOJMdMjuZPbesVsNhCUc0E%3D%0A&m=7yzJ1BGzZfWlgeq35UqNHc2YhJbN1S0UZ7vGy0ArYjc%3D%0A&s=8c40d293f3bcb442fc00faaf347e4e8d0c9514f2624fc75a8604f24bff88412f _______________________________________________ dev mailing list dev@openvswitch.org<mailto:dev@openvswitch.org> https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=f6EhnZ0ORGZNt5QbYmRaOxfWfx%2Bqd3KEiPf3%2FYaollU%3D%0A&m=7eOlWXeoqKefE0yDM6S3bvotnX8C4K4wEDOTH7Cuj%2FM%3D%0A&s=6851218affb2a57175b67d8e9bf7688db392ef7f23037e6a8f980c477d09eca3 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
