Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-23 Thread Justin Pettit
On May 23, 2012, at 11:50 PM, Naga Rohit, IIT Guwahati wrote: > On Thu, May 24, 2012 at 11:49 AM, Justin Pettit wrote: >> On May 23, 2012, at 10:40 PM, Naga Rohit, IIT Guwahati wrote: >> >>> On Wed, May 23, 2012 at 9:31 PM, Ben Pfaff wrote: On Wed, May 23, 2012 at 11:44:58AM +0530, Naga Ro

Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-23 Thread Naga Rohit, IIT Guwahati
On Thu, May 24, 2012 at 11:49 AM, Justin Pettit wrote: > On May 23, 2012, at 10:40 PM, Naga Rohit, IIT Guwahati wrote: > >> On Wed, May 23, 2012 at 9:31 PM, Ben Pfaff wrote: >>> On Wed, May 23, 2012 at 11:44:58AM +0530, Naga Rohit, IIT Guwahati wrote: Thanks for the quick response Mr Ben. Ho

Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-23 Thread Justin Pettit
On May 23, 2012, at 10:40 PM, Naga Rohit, IIT Guwahati wrote: > On Wed, May 23, 2012 at 9:31 PM, Ben Pfaff wrote: >> On Wed, May 23, 2012 at 11:44:58AM +0530, Naga Rohit, IIT Guwahati wrote: >>> Thanks for the quick response Mr Ben. However, I am bit confused on >>> which part of the code is resp

Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-23 Thread Naga Rohit, IIT Guwahati
On Wed, May 23, 2012 at 9:31 PM, Ben Pfaff wrote: > On Wed, May 23, 2012 at 11:44:58AM +0530, Naga Rohit, IIT Guwahati wrote: >> Thanks for the quick response Mr Ben. However, I am bit confused on >> which part of the code is responsible for the optimizations.. > > I already told you: ofproto-dpif

Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-23 Thread Ben Pfaff
On Wed, May 23, 2012 at 11:44:58AM +0530, Naga Rohit, IIT Guwahati wrote: > Thanks for the quick response Mr Ben. However, I am bit confused on > which part of the code is responsible for the optimizations.. I already told you: ofproto-dpif.c. > FILE: ~/openvswitch/lib/dpif.c > > Guessing the fu

Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-23 Thread Naga Rohit, IIT Guwahati
Thanks for the quick response Mr Ben. However, I am bit confused on which part of the code is responsible for the optimizations.. FILE: ~/openvswitch/lib/dpif.c Guessing the functionality, I found "dpif_flow_put" to be probably responsible for it. It is being called by "facet_put__" in ~/openvswi

Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-22 Thread Naga Rohit, IIT Guwahati
Thanks for the quick response Mr Ben. However, I am bit confused on which part of the code is responsible for the optimizations.. FILE: ~/openvswitch/lib/dpif.c Guessing the functionality, I found "dpif_flow_put" to be probably responsible for it. It is being called by "facet_put__" in ~/openvswi

Re: [ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-22 Thread Ben Pfaff
On Wed, May 23, 2012 at 10:44:45AM +0530, Naga Rohit, IIT Guwahati wrote: > Where am I going wrong ? Does the changes I have made really result in > behavior that I intend to see ? Code in ofproto-dpif.c "optimizes out" actions that it considers redundant, including consecutive changes to the VLAN

[ovs-dev] OVS Push VLAN Tag Hack and Problem

2012-05-22 Thread Naga Rohit, IIT Guwahati
Hi, I was working on a hack which can change the behavior of "mod_vlan_vid" action and behave as "push_vlan" for a quick temporary OF1.1 support. For this, I changed the following two functions: (PS: I am using mininet framework) FILE: ~/openvswitch/datapath/actions.c FUNCTION: static struct sk_b