sse Gross'
> Cc: b...@nicira.com; dev@openvswitch.org
> Subject: RE: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
>
>
> Ravi,
>
> I spent some time to test your most recent version of this patch.
> Using the very simple test environment that I described befor
Ravi,
I spent some time to test your most recent version of this patch.
Using the very simple test environment that I described before
consisting of just two machines talking to each other with a single
level of tagging I encountered several issues. These included not
only the hardware offloadin
On Fri, Mar 23, 2012 at 9:04 AM, wrote:
>
>
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Thursday, March 22, 2012 10:56 AM
> To: Kerur, Ravi
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for
On Fri, Mar 23, 2012 at 06:31:34PM +0100, r.ke...@telekom.com wrote:
>
>
> -Original Message-
> From: Ben Pfaff [mailto:b...@nicira.com]
> Sent: Friday, March 23, 2012 9:44 AM
> To: Kerur, Ravi
> Cc: dev@openvswitch.org; bda...@nicira.com
> Subject: Re: MPLS important comments (was: Re:
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Friday, March 23, 2012 9:44 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org; bda...@nicira.com
Subject: Re: MPLS important comments (was: Re: [ovs-dev] Patch for MPLS)
On Thu, Mar 22, 2012 at 11:03:10AM -0700, Ben Pfaff wrote:
On Thu, Mar 22, 2012 at 11:03:10AM -0700, Ben Pfaff wrote:
> On Tue, Mar 13, 2012 at 08:13:11PM +0100, ravi.ke...@telekom.com wrote:
> > > It appears that push_mpls() refuses to add an MPLS header if there is
> > > a VLAN tag and the inner Ethertype is not IPv4. Why?
> > >
> > > I didn't think an
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Thursday, March 22, 2012 10:56 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
On Wed, Mar 14, 2012 at 06:17:46PM +0100, ker...@telekom.de wrote:
>
ginal Message-
From: Jesse Gross [mailto:je...@nicira.com]
Sent: Thursday, March 22, 2012 5:02 PM
To: Kerur, Ravi
Cc: b...@nicira.com; dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
On Thu, Mar 22, 2012 at 2:08 PM, wrote:
> Hi Jesse,
>
&g
-Original Message-
From: Jesse Gross [mailto:je...@nicira.com]
Sent: Thursday, March 22, 2012 6:16 PM
To: Kerur, Ravi
Cc: b...@nicira.com; dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
On Thu, Mar 22, 2012 at 3:00 PM, wrote:
> Ok tha
On Thu, Mar 22, 2012 at 3:00 PM, wrote:
> Ok thanks will wait for Jesse's inputs on kernel code. Sent latest patch in
> our automated unit-test discussion.
Please don't wait for me. I'm not planning on reviewing the code
further until the points that I mentioned before have been addressed.
___
On Thu, Mar 22, 2012 at 2:08 PM, wrote:
> Hi Jesse,
>
> Please note that I work in labs environment and I volunteer my time for this
> and I have very limited resources to test. I have done testing related to
> complete mpls actions via the test-program written which is in
> tests/test-mpls.c.
Ok thanks will wait for Jesse's inputs on kernel code. Sent latest patch in our
automated unit-test discussion.
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Thursday, March 22, 2012 11:03 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org
Subject: Re: MPLS important comment
1/1.2
specification.
Thanks
Ravi
-Original Message-
From: Jesse Gross [mailto:je...@nicira.com]
Sent: Thursday, March 22, 2012 11:46 AM
To: Ben Pfaff
Cc: Kerur, Ravi; dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
On Thu, Mar 22, 2012 at 11:03
On Thu, Mar 22, 2012 at 11:03 AM, Ben Pfaff wrote:
> Sorry. I cannot accept half-finished code. I especially cannot take
> changes to the datapath without Jesse's approval, and I don't have
> that yet.
I've been hoping that things would settle down a little bit before
really taking a look at it
On Tue, Mar 13, 2012 at 08:13:11PM +0100, ravi.ke...@telekom.com wrote:
> Thanks again Ben. Comments inline
Why don't you quote in a normal way, with some kind of indentation?
These markers are hard to spot.
Most of your responses make perfect sense to me. Thanks.
Can you post your current pa
On Wed, Mar 14, 2012 at 06:17:46PM +0100, ker...@telekom.de wrote:
> We don't put unfinished code into our repository. You can make your
> life easier, though, a couple of ways. First, there's no need to
> merge or rebase often. You don't even have to do it before sending
> out a revised patch,
: dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
Hi Ben,
I don't have 3.2 kernel handy. When I ran exact command on 3.0 kernel I don't
see any warnings. I have fixed the issues but no way to verify currently. I
will do some basic testing and send ou
-
From: dev-boun...@openvswitch.org [mailto:dev-boun...@openvswitch.org] On
Behalf Of Kerur, Ravi
Sent: Tuesday, March 13, 2012 12:13 PM
To: b...@nicira.com
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS)
Ok thanks. I will test it out and se
Ok thanks. I will test it out and send another patch shortly.
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Tuesday, March 13, 2012 11:41 AM
To: Kerur, Ravi
Cc: je...@nicira.com; dev@openvswitch.org
Subject: Re: MPLS important comments (was: Re: [ovs-dev] Patch for MPLS
Thanks again Ben. Comments inline
On Mon, Mar 12, 2012 at 09:58:15PM +0100, ravi.ke...@telekom.com wrote:
> flow_extract() now has code to skip over inner VLAN tags. What's the
> rationale for that? It seems unwise to me, because it makes it
> impossible for a controller to distinguish a packet
Try using C=1 CF="-Wsparse-all -D__CHECK_ENDIAN__", which will uncover
more issues.
I'm using Linux 3.2.
On Tue, Mar 13, 2012 at 07:38:11PM +0100, ravi.ke...@telekom.com wrote:
> Thanks Ben, on what Linux version you are testing this? When I sent out the
> patch yesterday I had tested "make C=1"
Thanks Ben, on what Linux version you are testing this? When I sent out the
patch yesterday I had tested "make C=1" on Ubuntu 11.10(3.0 kernel) and CentOS
6.2(2.6 kernel) and had not seen sparse issues. I re-ran "make C=1" again today
with the patch I sent out yesterday and didn't see any warnin
Thanks for the patch, it applies cleanly against current "master". (I
had missed it on the first pass through my inbox this morning.)
I see the following "sparse" warnings for the kernel code. It
otherwise builds cleanly, and I can confirm that the unit tests pass
for me.
actions.c:244:36: warn
Ravi, thank you for such a fast turnaround! Are you planning to post
a revised patch this week?
I'm snipping the bits in your reply that make sense and don't need a
response.
On Mon, Mar 12, 2012 at 09:58:15PM +0100, ravi.ke...@telekom.com wrote:
> flow_extract() now has code to skip over inner
Thanks Ben for the review. Please see inline for , mostly agreeing to
changes, but some requires inputs/clarifications.
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Friday, March 09, 2012 11:20 AM
To: Kerur, Ravi
Cc: dev@openvswitch.org
Subject: MPLS important comme
Thank you for the patch! I have some comments. I'm dividing them
into two groups. The first group, in this email, is comments that
point out likely bugs. The second group, which I will send
separately, is comments that point out less important issues.
I didn't review the kernel code. That wil
26 matches
Mail list logo
