Hi Jesse, Please note that I work in labs environment and I volunteer my time for this and I have very limited resources to test. I have done testing related to complete mpls actions via the test-program written which is in tests/test-mpls.c. I have done basic vlan/mpls integration testing as well using again tests/test-mpls.c. I have made sure "make check" and "make distcheck" matches the results of the code in git master. I have used existing tools(tcpdump, wireshark, netstat and others) to make sure packets going out of the interface are correctly formatted such that actions executed correctly. I have run valgrind to make sure there are no memleaks, use-after-free errors in the code added.
Currently there are issues related to automated tests w.r.t new actions that are added and being actively discussed with Ben. If you have a testbed on which you would like me to do the testing let me know I will be happy to do it. As it stands, I do not have extensive testbed setup to do any further testing nor will I be approved to have one since it requires us to purchase new equipments. All mpls and vlan qinq actions are implemented based on OF 1.1/1.2 specification. Thanks Ravi -----Original Message----- From: Jesse Gross [mailto:je...@nicira.com] Sent: Thursday, March 22, 2012 11:46 AM To: Ben Pfaff Cc: Kerur, Ravi; dev@openvswitch.org Subject: Re: [ovs-dev] MPLS important comments (was: Re: Patch for MPLS) On Thu, Mar 22, 2012 at 11:03 AM, Ben Pfaff <b...@nicira.com> wrote: > Sorry. I cannot accept half-finished code. I especially cannot take > changes to the datapath without Jesse's approval, and I don't have > that yet. I've been hoping that things would settle down a little bit before really taking a look at it. I also see at least one TODO comment in the code that I'd like to see fixed first. Finally, there have been a few topics that have come up in the past, such as handling the various TTL operations with a single set action like we do with IP and the impact of imposing an MPLS tag on hardware offloading that need to be addressed or at least discussed. Ravi, how are you testing this? I would expect that offloaded traffic would have a difficult time passing through after a label is added. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
