Re: [ovs-dev] [PATCH v2] Adds parsing of OpenFlow 1.1+ Metadata

2012-06-21 Thread Ben Pfaff
[resending because 1340179423-24732-1-git-send-email-...@wand.net.nz is not an email address, it's a message ID. How did it end up in Reply-To:?] On Fri, Jun 22, 2012 at 01:53:07AM +1200, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > v2: Uses only OXM_OF_METADATA > > I've added to fl

Re: [ovs-dev] [PATCH v2] Adds parsing of OpenFlow 1.1+ Metadata

2012-06-21 Thread Ben Pfaff
On Fri, Jun 22, 2012 at 01:53:07AM +1200, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > v2: Uses only OXM_OF_METADATA > > I've added to flow_extract() so it sets the metadata field in the rule. Oops, I missed your questions on the first review, sorry. I don't think that flow_extract

[ovs-dev] [PATCH v2] Adds parsing of OpenFlow 1.1+ Metadata

2012-06-21 Thread Joe Stringer
Signed-off-by: Joe Stringer --- v2: Uses only OXM_OF_METADATA I've added to flow_extract() so it sets the metadata field in the rule. ofproto-dpif.c, handle_miss_upcalls() - Question. I've made this function set the metadata based on the miss structure, is this sufficient? Do I need to change an