On Fri, Jun 22, 2012 at 01:53:07AM +1200, Joe Stringer wrote: > Signed-off-by: Joe Stringer <j...@wand.net.nz> > --- > v2: Uses only OXM_OF_METADATA > > I've added to flow_extract() so it sets the metadata field in the rule.
Oops, I missed your questions on the first review, sorry. I don't think that flow_extract() needs to set the metadata at all. (Well, to zero.) The metadata field is logically equivalent to the OVS registers in that a packet coming in doesn't have any metadata or register values initially. That is, these fields are just internal bookkeeping and one wouldn't expect to have them pre-set on a packet arriving from the outside world. > ofproto-dpif.c, handle_miss_upcalls() - Question. I've made this function set > the metadata based on the miss structure, is this sufficient? Do I need to > change anything about how the miss structure interacts with the new metadata > field? I think that when you drop the flow_extract() parameter that will take care of it properly. > Also in ofproto-dpif.c, in ofproto_unixctl_trace() I've added an extra > argument > to specify the metadata, is there some corresponding documentation that I > should change along with this? I wouldn't change ofproto_unixctl_trace() at all according to the same reasoning above. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
