Re: [ovs-dev] [threaded-put 06/21] ofproto: Modularize netflow.

2013-12-12 Thread Ethan Jackson
> I think that the flow parameter to netflow_expire(), > netflow_flow_clear(), and netflow_flow_update() could be const. Actually none of them can because they either much with the flows hmap or the packet. I could const cast them, but it doesn't seem worth it. > Acked-by: Ben Pfaff I've folde

Re: [ovs-dev] [threaded-put 06/21] ofproto: Modularize netflow.

2013-12-12 Thread Ben Pfaff
On Sun, Dec 08, 2013 at 06:45:12PM -0800, Ethan Jackson wrote: > The netflow code has its tentacles all over the ofproto-dpif module. > This is fine today, but in future facets, which correspond roughly to > netflow_flows, will be retired. In preparation, this patch hides as > much implementation

[ovs-dev] [threaded-put 06/21] ofproto: Modularize netflow.

2013-12-08 Thread Ethan Jackson
The netflow code has its tentacles all over the ofproto-dpif module. This is fine today, but in future facets, which correspond roughly to netflow_flows, will be retired. In preparation, this patch hides as much implementation detail as possible inside the netflow module. Signed-off-by: Ethan Jac