Re: [ovs-dev] [port-ranges 3/3] Add support for bitwise matching on TCP and UDP ports.

2012-02-03 Thread Ben Pfaff
On Thu, Feb 02, 2012 at 05:51:22PM -0800, Justin Pettit wrote: > Ethan already covered the code part, but just a couple of questions on the > documentation: > > > +Bitwise matches on transport ports are rarely useful in isolation, but > > +a group of them can be used to reduce the number of flows

Re: [ovs-dev] [port-ranges 3/3] Add support for bitwise matching on TCP and UDP ports.

2012-02-02 Thread Justin Pettit
Ethan already covered the code part, but just a couple of questions on the documentation: > +Bitwise matches on transport ports are rarely useful in isolation, but > +a group of them can be used to reduce the number of flows required to > +match on a range of transport ports. For example, suppos

Re: [ovs-dev] [port-ranges 3/3] Add support for bitwise matching on TCP and UDP ports.

2012-02-02 Thread Ben Pfaff
Thank you for the reviews. I pushed this to master, with the improvement you pointed out in patch 2. On Thu, Feb 02, 2012 at 12:46:56PM -0800, Ethan Jackson wrote: > Looks good, > > Ethan > > On Fri, Jan 27, 2012 at 17:18, Ben Pfaff wrote: > > Bug #8827. > > Signed-off-by: Ben Pfaff > > --- >

Re: [ovs-dev] [port-ranges 3/3] Add support for bitwise matching on TCP and UDP ports.

2012-02-02 Thread Ethan Jackson
Looks good, Ethan On Fri, Jan 27, 2012 at 17:18, Ben Pfaff wrote: > Bug #8827. > Signed-off-by: Ben Pfaff > --- >  NEWS                          |    3 ++ >  include/openflow/nicira-ext.h |   10 - >  lib/classifier.c              |   77 +++ >  lib/classif

[ovs-dev] [port-ranges 3/3] Add support for bitwise matching on TCP and UDP ports.

2012-01-27 Thread Ben Pfaff
Bug #8827. Signed-off-by: Ben Pfaff --- NEWS |3 ++ include/openflow/nicira-ext.h | 10 - lib/classifier.c | 77 +++ lib/classifier.h |6 +++- lib/flow.c| 44 ++