On Tue, Jan 03, 2012 at 02:24:12PM -0800, Ben Pfaff wrote:
> On Tue, Jan 03, 2012 at 04:02:44PM -0600, Ethan Jackson wrote:
> > Looking through the ofproto-dpif code, all of the callers either do or
> > *should* be cloning the packet when using a packet_in action. One
> > caller in handle_miss_upc
On Tue, Jan 03, 2012 at 04:02:44PM -0600, Ethan Jackson wrote:
> Looking through the ofproto-dpif code, all of the callers either do or
> *should* be cloning the packet when using a packet_in action. One
> caller in handle_miss_upcalls, doesn't clone, but should because it
> later reuses the packe
> Although it would be ideal to embed the new structure inside struct
> flow, I actually had in mind to define a structure that wasn't
> necessarily used inside struct flow. It seems to me that such an
> approach would better than individual members, even if it falls short
> of perfection.
That's
Everything made sense, just a few responses:
On Tue, Jan 03, 2012 at 03:46:47PM -0600, Ethan Jackson wrote:
> > It might be reasonable to reuse the NXFF_* values for the 'format'
> > member in nxt_set_packet_in_format, instead of defining new NXPIF_*
> > values. ?Or you could even define a new NXF
> ../lib/ofp-util.c: In function 'ofputil_decode_packet_in':
> ../lib/ofp-util.c:1613: error: too many arguments to function
> 'nx_pull_match'
> ../lib/ofp-util.c: In function 'ofputil_encode_packet_in':
> ../lib/ofp-util.c:1693: error: too many arguments to function
> 'nx_put_match'
On Thu, Dec 29, 2011 at 01:05:38PM -0800, Ethan Jackson wrote:
> The new PACKET_IN format implemented in this patch includes flow
> metadata such as the cookie, table_id, and registers.
>
> Signed-off-by: Ethan Jackson
I get some compile errors (maybe as a symptom of conflicting changes?
or mayb
Please review this version.
Ethan
On Thu, Dec 29, 2011 at 16:05, Ethan Jackson wrote:
> The new PACKET_IN format implemented in this patch includes flow
> metadata such as the cookie, table_id, and registers.
>
> Signed-off-by: Ethan Jackson
> ---
> include/openflow/nicira-ext.h | 46 +++
The new PACKET_IN format implemented in this patch includes flow
metadata such as the cookie, table_id, and registers.
Signed-off-by: Ethan Jackson
---
include/openflow/nicira-ext.h | 46 +-
lib/learning-switch.c |2 +
lib/nx-match.h|2 +-
lib/ofp-pr
Sounds good, this is what I've originally implemented so I'll stick with it in
accordance to your suggestion. I need to resend this patch due to rebasing from
master. Please don't review until then.
Ethan (iPhone)
On Dec 29, 2011, at 14:38, Justin Pettit wrote:
> I would leave it as a separa
The new PACKET_IN format implemented in this patch includes flow
metadata such as the cookie, table_id, and registers.
---
include/openflow/nicira-ext.h | 46 +-
lib/learning-switch.c |2 +
lib/nx-match.h|2 +-
lib/ofp-print.c | 34
10 matches
Mail list logo
