> Although it would be ideal to embed the new structure inside struct
> flow, I actually had in mind to define a structure that wasn't
> necessarily used inside struct flow.  It seems to me that such an
> approach would better than individual members, even if it falls short
> of perfection.

That's a good idea too.

Unrelated note:

Looking through the ofproto-dpif code, all of the callers either do or
*should* be cloning the packet when using a packet_in action.  One
caller in handle_miss_upcalls, doesn't clone, but should because it
later reuses the packet.  For this reason I'm going to remove support
for retaining ownership of the packet (e.g. callers must clone).

Ethan
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to