Re: [ovs-dev] [packet_in 08/13] tests: Unit test PACKET_IN.

2012-01-02 Thread Ben Pfaff
On Mon, Jan 02, 2012 at 11:12:47AM -0800, Ethan Jackson wrote: > Here's an incremental. As discussed offline, I decided to keep > ofctl_monitor.log. Thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [packet_in 08/13] tests: Unit test PACKET_IN.

2012-01-02 Thread Ethan Jackson
Here's an incremental. As discussed offline, I decided to keep ofctl_monitor.log. --- tests/ofproto-dpif.at | 67 + 1 files changed, 34 insertions(+), 33 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 73bca1d..f51d

Re: [ovs-dev] [packet_in 08/13] tests: Unit test PACKET_IN.

2011-12-29 Thread Ethan Jackson
> I guess we need to set up a primary controller to test packet buffering? > All of these packets are unbuffered.  Oh well, packet buffering probably > should have its own tests anyway. I was mostly interested in verifying that the future patches result in controller actions generating correct pac

Re: [ovs-dev] [packet_in 08/13] tests: Unit test PACKET_IN.

2011-12-29 Thread Ben Pfaff
Thank you for writing these tests! Ethernet source addresses shouldn't have the multicast bit set. I guess it doesn't matter for these tests but it's setting a bad example. It's probably better to use the [stderr] special case for AT_CHECK (see the Autoconf manual) rather than to explicitly redi

[ovs-dev] [packet_in 08/13] tests: Unit test PACKET_IN.

2011-12-28 Thread Ethan Jackson
--- tests/ofproto-dpif.at | 168 + 1 files changed, 168 insertions(+), 0 deletions(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 55d1500..73bca1d 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -165,6 +165,17