Thank you for writing these tests! Ethernet source addresses shouldn't have the multicast bit set. I guess it doesn't matter for these tests but it's setting a bad example.
It's probably better to use the [stderr] special case for AT_CHECK (see the Autoconf manual) rather than to explicitly redirect stderr to a log file. (If you do keep it the way it is, then you can just put AT_CAPTURE_FILE once instead of repeating it, and you can put a line break before it, it doesn't have to be jammed onto the same line as AT_CHECK). There's a STRIP_DURATION macro that you can use in place of the explicit 'sed' invocation. I guess we need to set up a primary controller to test packet buffering? All of these packets are unbuffered. Oh well, packet buffering probably should have its own tests anyway. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
