On Tue, Apr 17, 2012 at 01:23:26PM -0700, Ethan Jackson wrote:
> > I agree that this fixes a problem, but the exit path in this function
> > is hard to understand. How about this instead:
>
> Good idea, I took your diff and tweaked it a bit to come up with the
> following.
Looks good, thanks.
_
> I agree that this fixes a problem, but the exit path in this function
> is hard to understand. How about this instead:
Good idea, I took your diff and tweaked it a bit to come up with the following.
---
lib/socket-util.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
On Mon, Apr 16, 2012 at 02:17:49PM -0700, Ethan Jackson wrote:
> If socket-util failed to modify the dscp bits of an active
> connection, it would fail to close the file descriptor potentially
> causing a leak. Found by inspection.
>
> Signed-off-by: Ethan Jackson
I agree that this fixes a probl
If socket-util failed to modify the dscp bits of an active
connection, it would fail to close the file descriptor potentially
causing a leak. Found by inspection.
Signed-off-by: Ethan Jackson
---
lib/socket-util.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/socket-
