If socket-util failed to modify the dscp bits of an active
connection, it would fail to close the file descriptor potentially
causing a leak. Found by inspection.
Signed-off-by: Ethan Jackson <et...@nicira.com>
---
lib/socket-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/socket-util.c b/lib/socket-util.c
index 6554e97..71f79bd 100644
--- a/lib/socket-util.c
+++ b/lib/socket-util.c
@@ -581,7 +581,7 @@ inet_open_active(int style, const char *target, uint16_t
default_port,
if (setsockopt(fd, IPPROTO_IP, IP_TOS, &dscp, sizeof dscp)) {
VLOG_ERR("%s: socket: %s", target, strerror(errno));
error = errno;
- goto exit;
+ goto exit_close;
}
}
--
1.7.9.6
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
