Re: [ovs-dev] [cleanups 08/12] bridge: Introduce iface_is_internal() function.

2012-11-16 Thread Justin Pettit
On Nov 16, 2012, at 9:51 AM, Ben Pfaff wrote: > On Fri, Nov 16, 2012 at 12:03:01AM -0800, Justin Pettit wrote: >> This will have an additional caller in the future. >> >> Signed-off-by: Justin Pettit > > I would think it more natural to write this: > >if (!strcmp(iface->type, "internal")

Re: [ovs-dev] [cleanups 08/12] bridge: Introduce iface_is_internal() function.

2012-11-16 Thread Ben Pfaff
On Fri, Nov 16, 2012 at 12:03:01AM -0800, Justin Pettit wrote: > This will have an additional caller in the future. > > Signed-off-by: Justin Pettit I would think it more natural to write this: if (!strcmp(iface->type, "internal") || !strcmp(iface->name, br->name)) { return true;

[ovs-dev] [cleanups 08/12] bridge: Introduce iface_is_internal() function.

2012-11-16 Thread Justin Pettit
This will have an additional caller in the future. Signed-off-by: Justin Pettit --- vswitchd/bridge.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index dbce59a..b600a3c 100644 --- a/vswitchd/bridge.c +++ b/vswitch