On Nov 16, 2012, at 9:51 AM, Ben Pfaff <b...@nicira.com> wrote:
> On Fri, Nov 16, 2012 at 12:03:01AM -0800, Justin Pettit wrote:
>> This will have an additional caller in the future.
>>
>> Signed-off-by: Justin Pettit <jpet...@nicira.com>
>
> I would think it more natural to write this:
>
> if (!strcmp(iface->type, "internal") || !strcmp(iface->name, br->name)) {
> return true;
> } else {
> return false;
> }
>
> as:
>
> return !strcmp(iface->type, "internal") || !strcmp(iface->name, br->name);
That is cleaner. Thanks.
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
