Re: [ovs-dev] [bond 3/7] bond: Add ovs-appctl bond/show to LACP sanity checks.

2012-01-12 Thread Ben Pfaff
On Thu, Jan 12, 2012 at 05:04:04PM -0800, Ethan Jackson wrote: > That's fine with me. Here's the code without renaming the tests. Looks good to me. Thank you. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [bond 3/7] bond: Add ovs-appctl bond/show to LACP sanity checks.

2012-01-12 Thread Ethan Jackson
That's fine with me. Here's the code without renaming the tests. --- tests/lacp.at | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tests/lacp.at b/tests/lacp.at index de7a3a7..16daa3d 100644 --- a/tests/lacp.at +++ b/tests/lacp.at @@ -6,8 +6,7 @@ OV

Re: [ovs-dev] [bond 3/7] bond: Add ovs-appctl bond/show to LACP sanity checks.

2012-01-12 Thread Ben Pfaff
On Thu, Jan 12, 2012 at 04:25:33PM -0800, Ethan Jackson wrote: > > Hmm. ?The "bond - single port" test is a bit paradoxical seeing as a > > single port isn't a bond. ?I guess it illustrates that LACP works with > > a single port too. > > Yes, I wanted to verify that a bond doesn't get created in t

Re: [ovs-dev] [bond 3/7] bond: Add ovs-appctl bond/show to LACP sanity checks.

2012-01-12 Thread Ethan Jackson
> Hmm.  The "bond - single port" test is a bit paradoxical seeing as a > single port isn't a bond.  I guess it illustrates that LACP works with > a single port too. Yes, I wanted to verify that a bond doesn't get created in this case. Would you prefer I rename it, or change the test in some way?

Re: [ovs-dev] [bond 3/7] bond: Add ovs-appctl bond/show to LACP sanity checks.

2012-01-12 Thread Ben Pfaff
On Thu, Jan 12, 2012 at 11:40:00AM -0800, Ethan Jackson wrote: > This commit makes the LACP unit tests more general by adding > ovs-appctl bond/show output. > > Signed-off-by: Ethan Jackson Hmm. The "bond - single port" test is a bit paradoxical seeing as a single port isn't a bond. I guess it

[ovs-dev] [bond 3/7] bond: Add ovs-appctl bond/show to LACP sanity checks.

2012-01-12 Thread Ethan Jackson
This commit makes the LACP unit tests more general by adding ovs-appctl bond/show output. Signed-off-by: Ethan Jackson --- tests/automake.mk |2 +- tests/{lacp.at => bond.at} | 26 +- tests/testsuite.at |2 +- 3 files changed, 23 insertions(+),