Re: [ovs-dev] [TCP_CRR 4/6] dpif-linux: Use "epoll" instead of poll().

2011-11-24 Thread Ben Pfaff
I didn't experiment. The dpif-linux fds have the advantage of being static and unchanging from one iteration to the next. It might be worth a try later. On Thu, Nov 24, 2011 at 10:28:45AM -0800, Justin Pettit wrote: > Looks good. Do you think there's benefit in using epoll in the main > poll li

Re: [ovs-dev] [TCP_CRR 4/6] dpif-linux: Use "epoll" instead of poll().

2011-11-24 Thread Justin Pettit
Looks good. Do you think there's benefit in using epoll in the main poll library? --Justin On Nov 22, 2011, at 3:12 PM, Ben Pfaff wrote: > epoll appears to be much more efficient than poll() at least for > static file descriptor sets. I can't otherwise explain why this > patch increases netp

[ovs-dev] [TCP_CRR 4/6] dpif-linux: Use "epoll" instead of poll().

2011-11-22 Thread Ben Pfaff
epoll appears to be much more efficient than poll() at least for static file descriptor sets. I can't otherwise explain why this patch increases netperf CRR performance by 20% above the previous commit, which is also about a 19% overall improvement versus the baseline from before the poll_fd_woke(