Re: [ovs-dev] [STP 9/9] ovs-vswitchd: Add support for 802.1D STP.

2011-10-22 Thread Justin Pettit
On Oct 21, 2011, at 4:35 PM, Ben Pfaff wrote: > On Fri, Oct 21, 2011 at 04:20:43PM -0700, Justin Pettit wrote: >> On Oct 18, 2011, at 1:23 PM, Ben Pfaff wrote: >> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >> index 025cc5b..065acf0 100644 >> --- a/ofproto/ofproto-dpif.c >> +++ b/

Re: [ovs-dev] [STP 9/9] ovs-vswitchd: Add support for 802.1D STP.

2011-10-21 Thread Ben Pfaff
On Fri, Oct 21, 2011 at 04:20:43PM -0700, Justin Pettit wrote: > On Oct 18, 2011, at 1:23 PM, Ben Pfaff wrote: > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 025cc5b..065acf0 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > @@ -967,6 +967,11 @@ set_stp(

Re: [ovs-dev] [STP 9/9] ovs-vswitchd: Add support for 802.1D STP.

2011-10-21 Thread Justin Pettit
On Oct 18, 2011, at 1:23 PM, Ben Pfaff wrote: I've dropped references to the minor, obviously correct issues you pointed out. > I'd be tempted to use a "struct stp_port *" in place of stp_port_num. > It might not be worth it. Up to you. That does make the code cleaner, so I changed it. > Some

Re: [ovs-dev] [STP 9/9] ovs-vswitchd: Add support for 802.1D STP.

2011-10-18 Thread Ben Pfaff
On Mon, Oct 17, 2011 at 10:31:49PM -0700, Justin Pettit wrote: > Add 802.1D spanning tree protocol support to ovs-vswitchd. Still needs > improvements in the following areas: > > * Does not work over bonds. > * Does not expire entries generated by the learning action when STP > stat

[ovs-dev] [STP 9/9] ovs-vswitchd: Add support for 802.1D STP.

2011-10-17 Thread Justin Pettit
Add 802.1D spanning tree protocol support to ovs-vswitchd. Still needs improvements in the following areas: * Does not work over bonds. * Does not expire entries generated by the learning action when STP state changes occur. * Needs more interoperability testing. Only tested ag