Re: [ovs-dev] [RFC v3 03/19] odp-util: Add tun_key to parse_odp_key_attr()

2012-05-17 Thread Simon Horman
On Thu, May 17, 2012 at 09:04:42AM -0700, Ben Pfaff wrote: > On Thu, May 17, 2012 at 05:59:02PM +0900, Simon Horman wrote: > > Cc: Kyle Mestery > > Signed-off-by: Simon Horman > > I think that this is inconsistent with patch 1, which I read as > printing these attributes in the form "ipv4_tunnel

Re: [ovs-dev] [RFC v3 03/19] odp-util: Add tun_key to parse_odp_key_attr()

2012-05-17 Thread Ben Pfaff
On Thu, May 17, 2012 at 05:59:02PM +0900, Simon Horman wrote: > Cc: Kyle Mestery > Signed-off-by: Simon Horman I think that this is inconsistent with patch 1, which I read as printing these attributes in the form "ipv4_tunnel(...)" not "tun_key(...)". The output form should be valid for input.

[ovs-dev] [RFC v3 03/19] odp-util: Add tun_key to parse_odp_key_attr()

2012-05-17 Thread Simon Horman
Cc: Kyle Mestery Signed-off-by: Simon Horman --- lib/odp-util.c | 24 1 file changed, 24 insertions(+) diff --git a/lib/odp-util.c b/lib/odp-util.c index 2829a85..7316e19 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -927,6 +927,30 @@ parse_odp_key_attr(const ch