On Thu, May 17, 2012 at 09:04:42AM -0700, Ben Pfaff wrote:
> On Thu, May 17, 2012 at 05:59:02PM +0900, Simon Horman wrote:
> > Cc: Kyle Mestery <[email protected]>
> > Signed-off-by: Simon Horman <[email protected]>
> 
> I think that this is inconsistent with patch 1, which I read as
> printing these attributes in the form "ipv4_tunnel(...)" not
> "tun_key(...)".  The output form should be valid for input.
> 
> You should add some tests for the ipv4_tunnel() formatting and parsing
> to tests/odp.at.

Thanks, I will fix that and add some tests.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to