Re: [ovs-dev] [RFC PATCH 3/4] lib/ofpbuf: Remove 'l7' pointer.

2014-03-25 Thread Jarno Rajahalme
On Mar 24, 2014, at 3:38 PM, Ben Pfaff wrote: > On Mon, Mar 24, 2014 at 10:59:05AM -0700, Jarno Rajahalme wrote: >> Now that we don't need to parse TCP flags from the packet after >> extraction, we usually do not need the 'l7' pointer any more. When >> needed, ofpbuf_get_tcp|udp|sctp|icmp_paylo

Re: [ovs-dev] [RFC PATCH 3/4] lib/ofpbuf: Remove 'l7' pointer.

2014-03-24 Thread Ben Pfaff
On Mon, Mar 24, 2014 at 10:59:05AM -0700, Jarno Rajahalme wrote: > Now that we don't need to parse TCP flags from the packet after > extraction, we usually do not need the 'l7' pointer any more. When > needed, ofpbuf_get_tcp|udp|sctp|icmp_payload() or ofpbuf_get_l4_size() > can be used instead. >

Re: [ovs-dev] [RFC PATCH 3/4] lib/ofpbuf: Remove 'l7' pointer.

2014-03-24 Thread Ben Pfaff
On Mon, Mar 24, 2014 at 02:53:44PM -0700, Pravin Shelar wrote: > On Mon, Mar 24, 2014 at 2:21 PM, Ben Pfaff wrote: > > On Mon, Mar 24, 2014 at 10:59:05AM -0700, Jarno Rajahalme wrote: > >> Now that we don't need to parse TCP flags from the packet after > >> extraction, we usually do not need the '

Re: [ovs-dev] [RFC PATCH 3/4] lib/ofpbuf: Remove 'l7' pointer.

2014-03-24 Thread Pravin Shelar
On Mon, Mar 24, 2014 at 2:21 PM, Ben Pfaff wrote: > On Mon, Mar 24, 2014 at 10:59:05AM -0700, Jarno Rajahalme wrote: >> Now that we don't need to parse TCP flags from the packet after >> extraction, we usually do not need the 'l7' pointer any more. When >> needed, ofpbuf_get_tcp|udp|sctp|icmp_pay

Re: [ovs-dev] [RFC PATCH 3/4] lib/ofpbuf: Remove 'l7' pointer.

2014-03-24 Thread Ben Pfaff
On Mon, Mar 24, 2014 at 10:59:05AM -0700, Jarno Rajahalme wrote: > Now that we don't need to parse TCP flags from the packet after > extraction, we usually do not need the 'l7' pointer any more. When > needed, ofpbuf_get_tcp|udp|sctp|icmp_payload() or ofpbuf_get_l4_size() > can be used instead. >

[ovs-dev] [RFC PATCH 3/4] lib/ofpbuf: Remove 'l7' pointer.

2014-03-24 Thread Jarno Rajahalme
Now that we don't need to parse TCP flags from the packet after extraction, we usually do not need the 'l7' pointer any more. When needed, ofpbuf_get_tcp|udp|sctp|icmp_payload() or ofpbuf_get_l4_size() can be used instead. Removal of 'l7' was requested by Pravin for the DPDK datapath work, as it