On Mon, Mar 24, 2014 at 10:59:05AM -0700, Jarno Rajahalme wrote:
> Now that we don't need to parse TCP flags from the packet after
> extraction, we usually do not need the 'l7' pointer any more.  When
> needed, ofpbuf_get_tcp|udp|sctp|icmp_payload() or ofpbuf_get_l4_size()
> can be used instead.
> 
> Removal of 'l7' was requested by Pravin for the DPDK datapath work, as
> it simplifies packet parsing a bit.
> 
> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>

This makes me a little sad, because I like the abstraction.  But it is
true that we don't use l7 much, so I guess it's OK to remove it to
increase performance slightly.

Is bfd_process_packet() unsafe?  I think that it should check that l7
is nonnull.

Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to