Re: [ovs-dev] [RFC PATCH] lib/odp-util: Relax expectations when parsing a masked key.

2014-09-12 Thread Ben Pfaff
On Thu, Sep 11, 2014 at 11:12:29AM -0700, Jarno Rajahalme wrote: > This could fix using ovs-dpctl to add userspace datapath flows. > > Signed-off-by: Jarno Rajahalme s/prerequisities/prerequisites/ in a comment somewhere. It looks like we need a new exception for the xregs in odp_flow_key_to_fl

Re: [ovs-dev] [RFC PATCH] lib/odp-util: Relax expectations when parsing a masked key.

2014-09-12 Thread Jarno Rajahalme
Ben, Are you happy with this? I really see this as something we could have done at the time we introduced datapath flow key masks (megaflows), but did not. The basic change is that we allow datapath flow setup without requiring key fields that are fully wildcarded to be present. Jarno On Se

Re: [ovs-dev] [RFC PATCH] lib/odp-util: Relax expectations when parsing a masked key.

2014-09-11 Thread Daniele Di Proietto
Hi Jarno, Thanks for the patch. The problem was that after the recent changes to odp-util.c {ovs-,ovs-appctl }dpctl do not work anymore. HereĀ¹s a line that used to work: ovs-appctl dpctl/add-flow dummy@br0 "in_port(1),eth(src=00:00:00:00:00:00/00:00:00:00:00:00,dst=ff:ff:ff:ff:ff: ff/00:00:00:00

Re: [ovs-dev] [RFC PATCH] lib/odp-util: Relax expectations when parsing a masked key.

2014-09-11 Thread Jarno Rajahalme
On Sep 11, 2014, at 11:11 AM, Ben Pfaff wrote: > On Thu, Sep 11, 2014 at 11:12:29AM -0700, Jarno Rajahalme wrote: >> This could fix using ovs-dpctl to add userspace datapath flows. > > It's a big patch, could you expand slightly on what it does before I > start reading it? I planned to follow

Re: [ovs-dev] [RFC PATCH] lib/odp-util: Relax expectations when parsing a masked key.

2014-09-11 Thread Ben Pfaff
On Thu, Sep 11, 2014 at 11:12:29AM -0700, Jarno Rajahalme wrote: > This could fix using ovs-dpctl to add userspace datapath flows. It's a big patch, could you expand slightly on what it does before I start reading it? ___ dev mailing list dev@openvswitch

[ovs-dev] [RFC PATCH] lib/odp-util: Relax expectations when parsing a masked key.

2014-09-11 Thread Jarno Rajahalme
This could fix using ovs-dpctl to add userspace datapath flows. Signed-off-by: Jarno Rajahalme --- lib/dpctl.c |4 +- lib/dpif-netdev.c | 85 --- lib/odp-util.c| 88 ++---