On Thu, Sep 11, 2014 at 11:12:29AM -0700, Jarno Rajahalme wrote:
> This could fix using ovs-dpctl to add userspace datapath flows.
> 
> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>

s/prerequisities/prerequisites/ in a comment somewhere.

It looks like we need a new exception for the xregs in
odp_flow_key_to_flow_and_mask(), though this is an existing bug in
dpif_netdev_mask_from_nlattrs() so maybe it should be called out as a
separate patch either before or after this one.

Given that this is about ovs-dpctl, I worry about how this changes the
code in revalidate_ukey() to take a more relaxed view of datapath
flows.  Do you have a rationale about why that's an OK thing to do?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to