Re: [ovs-dev] [RFC 03/14] revalidator: Use 'cmap' for storing ukeys.

2014-08-24 Thread Joe Stringer
On 23 August 2014 06:47, Ben Pfaff wrote: > On Thu, Aug 21, 2014 at 05:41:58PM +1200, Joe Stringer wrote: > > Signed-off-by: Joe Stringer > > As of this patch, there isn't an advantage to using a cmap yet, right? > Not yet, no. Cmaps become useful when access is spread across handler threads as

Re: [ovs-dev] [RFC 03/14] revalidator: Use 'cmap' for storing ukeys.

2014-08-22 Thread Ben Pfaff
On Thu, Aug 21, 2014 at 05:41:58PM +1200, Joe Stringer wrote: > Signed-off-by: Joe Stringer As of this patch, there isn't an advantage to using a cmap yet, right? Here, I'd be inclined to add the ovsrcu_quiesce() call outside the 'if' statement, unconditionally, because otherwise it's just a mat

[ovs-dev] [RFC 03/14] revalidator: Use 'cmap' for storing ukeys.

2014-08-20 Thread Joe Stringer
Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 61 ++--- 1 file changed, 33 insertions(+), 28 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 5f1d6d5..bccd7e8 100644 --- a/ofproto/ofproto-dpif-up