On Thu, Aug 21, 2014 at 05:41:58PM +1200, Joe Stringer wrote: > Signed-off-by: Joe Stringer <joestrin...@nicira.com>
As of this patch, there isn't an advantage to using a cmap yet, right? Here, I'd be inclined to add the ovsrcu_quiesce() call outside the 'if' statement, unconditionally, because otherwise it's just a matter of luck whether the number of ops happened to be a multiple of REVALIDATE_MAX_BATCH: > @@ -1582,6 +1587,7 @@ revalidate(struct revalidator *revalidator) > > if (n_ops) { > push_dump_ops__(udpif, ops, n_ops); > + ovsrcu_quiesce(); > } > } > dpif_flow_dump_thread_destroy(dump_thread); Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev