Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-06-02 Thread Joe Stringer
On 31 May 2014 13:27, Ethan Jackson wrote: > > I agree with the sentiment that it shouldn't be optional; that was my > first > > thought. Although, feedback from V1 was concerned about additional system > > resources required to run it like that. > > > > Perhaps a compromise is to have it configu

Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-30 Thread Ethan Jackson
> I agree with the sentiment that it shouldn't be optional; that was my first > thought. Although, feedback from V1 was concerned about additional system > resources required to run it like that. > > Perhaps a compromise is to have it configurable like this, but default to > -j8? I don't feel all

Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-29 Thread Joe Stringer
I agree with the sentiment that it shouldn't be optional; that was my first thought. Although, feedback from V1 was concerned about additional system resources required to run it like that. Perhaps a compromise is to have it configurable like this, but default to -j8? On 30 May 2014 08:20, Ethan

Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-29 Thread Ben Pfaff
It's your script. If you tell me it should have a feature that launches tuxracer, I'm not going to argue ;-) On Thu, May 29, 2014 at 01:20:03PM -0700, Ethan Jackson wrote: > Same versions. Looks like I had added this: export > TESTSUITEFLAGS="-j8" to my bashrc which is why I got parallelism. >

Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-29 Thread Ethan Jackson
Same versions. Looks like I had added this: export TESTSUITEFLAGS="-j8" to my bashrc which is why I got parallelism. I suppose my other comment is that I'd prefer this isn't optional. We hardcode parallelism for make, we might as well do it for make check. Ethan On Thu, May 29, 2014 at 1:17 PM

Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-29 Thread Ben Pfaff
It doesn't work for me with Autoconf 2.69 and GNU Make 3.81. What versions are you using? On Thu, May 29, 2014 at 1:13 PM, Ethan Jackson wrote: > On my system at leas,t the fact that we pass "-j 8" to make, > automagically causes the tests to run in parallel already. Does that > not work for you

Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-29 Thread Ethan Jackson
On my system at leas,t the fact that we pass "-j 8" to make, automagically causes the tests to run in parallel already. Does that not work for you? Ethan On Thu, May 29, 2014 at 10:12 AM, Ben Pfaff wrote: > Ethan, I think you should review this. > > On Mon, May 19, 2014 at 3:37 PM, Joe Stringer

Re: [ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-29 Thread Ben Pfaff
Ethan, I think you should review this. On Mon, May 19, 2014 at 3:37 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > v2: Make it configurable. > --- > utilities/ovs-dev.py |4 > 1 file changed, 4 insertions(+) > > diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py >

[ovs-dev] [PATCHv2] ovs-dev.py: Add option to run tests in parallel.

2014-05-19 Thread Joe Stringer
Signed-off-by: Joe Stringer --- v2: Make it configurable. --- utilities/ovs-dev.py |4 1 file changed, 4 insertions(+) diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py index 97fab6c..d08ef39 100755 --- a/utilities/ovs-dev.py +++ b/utilities/ovs-dev.py @@ -145,6 +145,8 @@ command