> I agree with the sentiment that it shouldn't be optional; that was my first
> thought. Although, feedback from V1 was concerned about additional system
> resources required to run it like that.
>
> Perhaps a compromise is to have it configurable like this, but default to
> -j8?
I don't feel all that strongly about it either way. I suppose I have
a bias towards less knobs, but if you think we should just change the
default, that's fine as well.
Ethan
>
> On 30 May 2014 08:20, Ethan Jackson <et...@nicira.com> wrote:
>>
>> Same versions. Looks like I had added this: export
>> TESTSUITEFLAGS="-j8" to my bashrc which is why I got parallelism.
>>
>> I suppose my other comment is that I'd prefer this isn't optional. We
>> hardcode parallelism for make, we might as well do it for make check.
>>
>> Ethan
>>
>> On Thu, May 29, 2014 at 1:17 PM, Ben Pfaff <b...@nicira.com> wrote:
>> > It doesn't work for me with Autoconf 2.69 and GNU Make 3.81.
>> > What versions are you using?
>> >
>> > On Thu, May 29, 2014 at 1:13 PM, Ethan Jackson <et...@nicira.com> wrote:
>> >> On my system at leas,t the fact that we pass "-j 8" to make,
>> >> automagically causes the tests to run in parallel already. Does that
>> >> not work for you?
>> >>
>> >> Ethan
>> >>
>> >> On Thu, May 29, 2014 at 10:12 AM, Ben Pfaff <b...@nicira.com> wrote:
>> >>> Ethan, I think you should review this.
>> >>>
>> >>> On Mon, May 19, 2014 at 3:37 PM, Joe Stringer <joestrin...@nicira.com>
>> >>> wrote:
>> >>>> Signed-off-by: Joe Stringer <joestrin...@nicira.com>
>> >>>> ---
>> >>>> v2: Make it configurable.
>> >>>> ---
>> >>>> utilities/ovs-dev.py | 4 ++++
>> >>>> 1 file changed, 4 insertions(+)
>> >>>>
>> >>>> diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
>> >>>> index 97fab6c..d08ef39 100755
>> >>>> --- a/utilities/ovs-dev.py
>> >>>> +++ b/utilities/ovs-dev.py
>> >>>> @@ -145,6 +145,8 @@ commands.append(make)
>> >>>>
>> >>>> def check():
>> >>>> flags = ""
>> >>>> + if options.parallel:
>> >>>> + flags += "-j%d " % options.parallel
>> >>>> if options.tests:
>> >>>> flags += options.tests
>> >>>> ENV["TESTSUITEFLAGS"] = flags
>> >>>> @@ -344,6 +346,8 @@ def main():
>> >>>> parser.add_option_group(group)
>> >>>>
>> >>>> group = optparse.OptionGroup(parser, "check")
>> >>>> + group.add_option("-p", dest="parallel", metavar="N_TESTS",
>> >>>> type="int",
>> >>>> + help="Run N_TESTS in parallel")
>> >>>> group.add_option("--tests", dest="tests", metavar="FILTER",
>> >>>> help="""run specific tests or a test category
>> >>>> eg, --tests=\"1-10\", --tests=\"-k
>> >>>> megaflow\"""")
>> >>>> --
>> >>>> 1.7.10.4
>> >>>>
>> >>>> _______________________________________________
>> >>>> dev mailing list
>> >>>> dev@openvswitch.org
>> >>>> http://openvswitch.org/mailman/listinfo/dev
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> "I don't normally do acked-by's. I think it's my way of avoiding
>> >>> getting blamed when it all blows up." Andrew Morton
>> >
>> >
>> >
>> > --
>> > "I don't normally do acked-by's. I think it's my way of avoiding
>> > getting blamed when it all blows up." Andrew Morton
>
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
