To: "Ryan Wilson"
Cc: dev@openvswitch.org
Sent: Monday, May 19, 2014 12:48:07 PM
Subject: Re: [ovs-dev] [PATCHv2] ofproto: Add support for Openflow group and
bucket stats.
Hey Ryan,
Still high level comments first,
Could you break the patch into three? (your change about cred
Hey Ryan,
Still high level comments first,
Could you break the patch into three? (your change about crediting the
group stats, Andy's test, and use RCU for group configuration)
The group stats crediting part of code looks good to me.
The test makes sense.
I haven't reviewed the "rcu for group c
This patch also adds a ref/unref structure for ofgroup, so handler and
revalidator threads can update group / bucket stats via the xlate cache.
Signed-off-by: Ryan Wilson
---
v2: Fixed bug with group stats all buckets, cleaned up ofgroup unref code,
added Andy Zhou's test for more complete t
