We should use Andy's patch for the tests since I didn't write the tests: http://patchwork.openvswitch.org/patch/3626/
I'll split the group RCU and the crediting stats parts of this commit on my next version. Ryan ----- Original Message ----- From: "Alex Wang" <al...@nicira.com> To: "Ryan Wilson" <wr...@nicira.com> Cc: dev@openvswitch.org Sent: Monday, May 19, 2014 12:48:07 PM Subject: Re: [ovs-dev] [PATCHv2] ofproto: Add support for Openflow group and bucket stats. Hey Ryan, Still high level comments first, Could you break the patch into three? (your change about crediting the group stats, Andy's test, and use RCU for group configuration) The group stats crediting part of code looks good to me. The test makes sense. I haven't reviewed the "rcu for group configuration", and will wait after your new post. Thanks, Alex Wang, _______________________________________________ dev mailing list dev@openvswitch.org https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=TfBS78Vw3dzttvXidhbffg%3D%3D%0A&m=Lc836A4MVrnzb3JHRDQXkg%2F3dFFogDj8%2FZHwucukzMA%3D%0A&s=fbda16450f6efa40ee9bbdb1455b6be9f73d7866d6517b7dc19862da217bc6ff
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
