On Thu, Aug 07, 2014 at 06:20:41AM +, Wenyu Zhang wrote:
> > > I'm not sure why tnl_xlate_init() has this new code:
> > > /* The tp_src and tp_dst members in flow_tnl are set to be always
> > > * wildcarded, not to unwildcard them here. */
> > > wc->masks.tunnel.tp_src
> > I'm not sure why tnl_xlate_init() has this new code:
> > /* The tp_src and tp_dst members in flow_tnl are set to be always
> > * wildcarded, not to unwildcard them here. */
> > wc->masks.tunnel.tp_src = 0;
> > wc->masks.tunnel.tp_dst = 0; Does it have any visibl
On Wed, Aug 06, 2014 at 09:55:14AM +, Wenyu Zhang wrote:
> Ben Pfaf writes:
> > In dpif_ipfix_add_tunnel_port(), the check for dip == NULL should be
> > removed. xmalloc() never returns NULL.
> You means that xmalloc() never fails? If it may fail, how shall I check it?
xmalloc() never fails.
Thanks for reviewing it. I am working on address the comments. And I add some
new comments inline.
Bests,
Wenyu
Important
-
This needs a rebase because openvswitch.h has moved.
There are sparse warnings and errors. I'll append a patch to fix these.
In datapath/flow_netlink.c, ipv4_
On Tue, Aug 05, 2014 at 10:29:55AM -0700, Jesse Gross wrote:
> On Tue, Aug 5, 2014 at 10:05 AM, Ben Pfaff wrote:
> > Why is Geneve restricted to a 24-bit key?
>
> The VNI in Geneve (as separate from the options) is 24 bit.
OK. I didn't realize (or forgot) that it had a separate VNI (GNI?).
On Tue, Aug 5, 2014 at 10:05 AM, Ben Pfaff wrote:
> Why is Geneve restricted to a 24-bit key?
The VNI in Geneve (as separate from the options) is 24 bit.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Jul 31, 2014 at 04:12:30AM -0700, Wenyu Zhang wrote:
> Extend IPFIX exporter to export tunnel headers when both input and output
> of the port.
> Add three other_config options in IPFIX table: enable-input-sampling,
> enable-output-sampling and enable-tunnel-sampling, to control whether
> s
Extend IPFIX exporter to export tunnel headers when both input and output
of the port.
Add three other_config options in IPFIX table: enable-input-sampling,
enable-output-sampling and enable-tunnel-sampling, to control whether
sampling tunnel info, on which direction (input or output).
Insert sampl
