On Wed, Aug 06, 2014 at 09:55:14AM +0000, Wenyu Zhang wrote: > Ben Pfaf writes: > > In dpif_ipfix_add_tunnel_port(), the check for dip == NULL should be > > removed. xmalloc() never returns NULL. > You means that xmalloc() never fails? If it may fail, how shall I check it?
xmalloc() never fails. > > I'm not sure why tnl_xlate_init() has this new code: > > /* The tp_src and tp_dst members in flow_tnl are set to be always > > * wildcarded, not to unwildcard them here. */ > > wc->masks.tunnel.tp_src = 0; > > wc->masks.tunnel.tp_dst = 0; > > Does it have any visible effect? It appears to me that these fields are > > already 0, as initialized by the caller. > Yes, the caller has initialized the whole data strusture in the > existent codes. But we think that we should set the two fileds as 0 > obviously in this function, to avoid potential issue if it is called > by other callers in future. OK, can you please submit that as a separate patch since it is a logically separate change? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
