Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Nithin Raju
> On May 27, 2015, at 9:06 AM, Sorin Vinturis > wrote: > > Nithin, > > I will address your comment in the next version of this patch. Sure. > Regarding the duplicate vport delete request, I have not found a way to > generate such request from userspace. When I use 'ovs-vsctl' application to

Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-27 Thread Sorin Vinturis
ithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 26 May, 2015 09:51 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port hi Sorin, This patch looks much better. Like I mentioned the review to the previous revision, a

Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-25 Thread Nithin Raju
> On May 25, 2015, at 11:50 PM, Nithin Raju wrote: > > > hi Sorin, > This patch looks much better. Like I mentioned the review to the previous > revision, a duplicate vport delete request for the same VXLAN port can mess > things up, including accessing a freed up ‘vport’ structure. But, that

Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-25 Thread Nithin Raju
hi Sorin, This patch looks much better. Like I mentioned the review to the previous revision, a duplicate vport delete request for the same VXLAN port can mess things up, including accessing a freed up ‘vport’ structure. But, that is a corner case, and we can address it later. I just found a n

[ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port

2015-05-25 Thread Sorin Vinturis
The kernel datapath supports only port 4789 for VXLAN tunnel creation. Added support in order to allow for the VXLAN tunnel port to be configurable to any port number set by the userspace. The patch also checks to see if an existing WFP filter, for the necessary UDP tunnel port, is already created