Nithin, I will address your comment in the next version of this patch.
Regarding the duplicate vport delete request, I have not found a way to generate such request from userspace. When I use 'ovs-vsctl' application to send a second delete request for a VXLAN interface, the app outputs an error message to the console without sending the delete request to the kernel. If there is a way to generate a duplicate vport delete request, please let me know so I can test the behavior and see if there are issues related to that. Thanks, Sorin -----Original Message----- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 26 May, 2015 09:51 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v6 1/3] datapath-windows: Support for custom VXLAN tunnel port hi Sorin, This patch looks much better. Like I mentioned the review to the previous revision, a duplicate vport delete request for the same VXLAN port can mess things up, including accessing a freed up ‘vport’ structure. But, that is a corner case, and we can address it later. I just found a new issue in OvsTunnelVportPendingUninit() where you are not taking the vport lock (switchContext->dispatchLock). Looks good otherwise. > +static VOID > +OvsTunnelVportPendingUninit(PVOID context, > + NTSTATUS status, > + UINT32 *replyLen) You are not taking the switchContext->dispatchLock while deleting from the hash tables. I should be able to ACK the next revision. thanks, -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
