Re: [ovs-dev] [PATCH v6] ofproto: Add reference count for Openflow groups.

2014-05-21 Thread Andy Zhou
On Wed, May 21, 2014 at 5:01 PM, Ryan Wilson 76511 wrote: > Some inline comments below. The only thing I'm a bit concerned about it is > the constant cast issue, especially since created / modified are actually > altered in modify_group(). > > Also, the problem is the struct-defined variables are

Re: [ovs-dev] [PATCH v6] ofproto: Add reference count for Openflow groups.

2014-05-21 Thread Ryan Wilson 76511
Some inline comments below. The only thing I'm a bit concerned about it is the constant cast issue, especially since created / modified are actually altered in modify_group(). Also, the problem is the struct-defined variables are constant, so CONST_CAST won't work here. (CONST_CAST works for conve

Re: [ovs-dev] [PATCH v6] ofproto: Add reference count for Openflow groups.

2014-05-21 Thread Andy Zhou
On Wed, May 21, 2014 at 2:14 PM, Ryan Wilson wrote: > When adding support for OpenFlow group and bucket stats, a group entry is > added > to the xlate_cache. If the main thread removes the group from an ofproto, we > need to guarantee that the group remains accessible to users of > xlate_group_ac

[ovs-dev] [PATCH v6] ofproto: Add reference count for Openflow groups.

2014-05-21 Thread Ryan Wilson
When adding support for OpenFlow group and bucket stats, a group entry is added to the xlate_cache. If the main thread removes the group from an ofproto, we need to guarantee that the group remains accessible to users of xlate_group_actions and the xlate_cache, as the xlate_cache will not be cleane